fix: prevent DJ enqueue from resetting active playback state#152
Merged
LivingLikeKrillin merged 1 commit intodevelopfrom Mar 29, 2026
Merged
fix: prevent DJ enqueue from resetting active playback state#152LivingLikeKrillin merged 1 commit intodevelopfrom
LivingLikeKrillin merged 1 commit intodevelopfrom
Conversation
enqueueDj() unconditionally called activate(null, null), overwriting currentPlaybackId when a second DJ registered during active playback. This caused NPE (500) on GET /dj-queue and any playbackId-dependent query. - Move activate(null, null) inside isPostActivationProcessingRequired guard - Add null check on currentPlaybackId in getDjQueueInfo for transient state Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
activate(null, null)호출이 기존 활성 playback 상태를 덮어쓰는 문제 수정getDjQueueInfo에서currentPlaybackIdnull 방어 처리 추가Root Cause
enqueueDj()가 무조건activate(null, null)을 호출하여, 두 번째 DJ 등록 시currentPlaybackId가 null로 초기화됨 →GET /dj-queue500 에러 (NPE)Test plan
:app:compileJava빌드 성공DjCommandService*테스트 통과PartyroomQueryServiceTest테스트 통과🤖 Generated with Claude Code